Commit 7839c672 authored Dec 07, 2017 by Marc Zyngier Committed by Christoffer Dall Dec 18, 2017

KVM: arm/arm64: Fix HYP unmapping going off limits



When we unmap the HYP memory, we try to be clever and unmap one
PGD at a time. If we start with a non-PGD aligned address and try
to unmap a whole PGD, things go horribly wrong in unmap_hyp_range
(addr and end can never match, and it all goes really badly as we
keep incrementing pgd and parse random memory as page tables...).

The obvious fix is to let unmap_hyp_range do what it does best,
which is to iterate over a range.

The size of the linear mapping, which begins at PAGE_OFFSET, can be
easily calculated by subtracting PAGE_OFFSET form high_memory, because
high_memory is defined as the linear map address of the last byte of
DRAM, plus one.

The size of the vmalloc region is given trivially by VMALLOC_END -
VMALLOC_START.

Cc: stable@vger.kernel.org
Reported-by: Andre Przywara <andre.przywara@arm.com>
Tested-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>

parent bfe766cf

virt/kvm/arm/mmu.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -509,8 +509,6 @@ static void unmap_hyp_range(pgd_t *pgdp, phys_addr_t start, u64 size)
		*/
		void free_hyp_pgds(void)
		{
		unsigned long addr;

		mutex_lock(&kvm_hyp_pgd_mutex);

		if (boot_hyp_pgd) {
		@@ -521,10 +519,10 @@ void free_hyp_pgds(void)

		if (hyp_pgd) {
		unmap_hyp_range(hyp_pgd, hyp_idmap_start, PAGE_SIZE);
		for (addr = PAGE_OFFSET; virt_addr_valid(addr); addr += PGDIR_SIZE)
		unmap_hyp_range(hyp_pgd, kern_hyp_va(addr), PGDIR_SIZE);
		for (addr = VMALLOC_START; is_vmalloc_addr((void*)addr); addr += PGDIR_SIZE)
		unmap_hyp_range(hyp_pgd, kern_hyp_va(addr), PGDIR_SIZE);
		unmap_hyp_range(hyp_pgd, kern_hyp_va(PAGE_OFFSET),
		(uintptr_t)high_memory - PAGE_OFFSET);
		unmap_hyp_range(hyp_pgd, kern_hyp_va(VMALLOC_START),
		VMALLOC_END - VMALLOC_START);

		free_pages((unsigned long)hyp_pgd, hyp_pgd_order);
		hyp_pgd = NULL;

Admin message