Commit 7828a3ef authored Aug 06, 2020 by Marc Zyngier

irqchip: Fix probing deferal when using IRQCHIP_PLATFORM_DRIVER helpers



When probing an interrupt controller that is behind a parent,
we try to check whether the parent domain is available as
an indication that we can actually try to probe.

Unfortunately, we are checking this with the firmware node of
the about to be probed device, not the parent. This is obviously
bound to fail.

Instead, use the parent node.

Fixes: f8410e62 ("irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END and IRQCHIP_MATCH helper macros")
Reported-by: John Stultz <john.stultz@linaro.org>
Tested-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>

parent 6da45875

drivers/irqchip/irqchip.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -52,7 +52,7 @@ int platform_irqchip_probe(struct platform_device *pdev)
		* interrupt controller. The actual initialization callback of this
		* interrupt controller can check for specific domains as necessary.
		*/
		if (par_np && !irq_find_matching_host(np, DOMAIN_BUS_ANY))
		if (par_np && !irq_find_matching_host(par_np, DOMAIN_BUS_ANY))
		return -EPROBE_DEFER;

		return irq_init_cb(np, par_np);

Admin message