Commit 781978e6 authored Apr 27, 2015 by Joonwoo Park Committed by Thomas Gleixner May 05, 2015

timer: Use timer->base for flag checks

At present, internal_add_timer() examines flags with 'base' which doesn't
contain flags.  Examine with 'timer->base' to avoid unnecessary waking up
of nohz CPU when timer base has TIMER_DEFERRABLE set.

Signed-off-by: Joonwoo Park <joonwoop@codeaurora.org>
Cc: sboyd@codeaurora.org
Cc: skannan@codeaurora.org
Cc: John Stultz <john.stultz@linaro.org>
Link: http://lkml.kernel.org/r/1430187709-21087-1-git-send-email-joonwoop@codeaurora.org

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 9fa8cc0a

kernel/time/timer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -436,7 +436,7 @@ static void internal_add_timer(struct tvec_base base, struct timer_list timer)
		* require special care against races with idle_cpu(), lets deal
		* with that later.
		*/
		if (!tbase_get_deferrable(base) \|\| tick_nohz_full_cpu(base->cpu))
		if (!tbase_get_deferrable(timer->base) \|\| tick_nohz_full_cpu(base->cpu))
		wake_up_nohz_cpu(base->cpu);
		}

Admin message