btrfs: Remove unused btrfs_start_transaction_lflush function (7806c6eb) · Commits · 戴 / test

Commit ("Btrfs: fix lots of orphan inodes when the space is not enough") changed the way transaction reservation is made in btrfs_evict_node and as a result this function became unused. This has been the status quo for 5 years in which time no one noticed, so I'd say it's safe to assume it's unlikely it will ever be used again. Historical note: there were more attempts to remove the function, the reasoning was missing and only based on some static analysis tool reports. Other reason for rejection was that there seemed to be connection to BTRFS_RESERVE_FLUSH_LIMIT and that would need to be removeed to. This was not correct so removing the function is all we can do. Signed-off-by:

Nikolay Borisov <nborisov@suse.com> [ add the note ] Signed-off-by:

David Sterba <dsterba@suse.com>

fs/btrfs/transaction.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -658,14 +658,6 @@ struct btrfs_trans_handle *btrfs_start_transaction_fallback_global_rsv(
		return trans;
		}

		struct btrfs_trans_handle *btrfs_start_transaction_lflush(
		struct btrfs_root *root,
		unsigned int num_items)
		{
		return start_transaction(root, num_items, TRANS_START,
		BTRFS_RESERVE_FLUSH_LIMIT, true);
		}

		struct btrfs_trans_handle btrfs_join_transaction(struct btrfs_root root)
		{
		return start_transaction(root, 0, TRANS_JOIN, BTRFS_RESERVE_NO_FLUSH,

fs/btrfs/transaction.h

+0 −3

Original line number	Diff line number	Diff line
		@@ -186,9 +186,6 @@ struct btrfs_trans_handle *btrfs_start_transaction_fallback_global_rsv(
		struct btrfs_root *root,
		unsigned int num_items,
		int min_factor);
		struct btrfs_trans_handle *btrfs_start_transaction_lflush(
		struct btrfs_root *root,
		unsigned int num_items);
		struct btrfs_trans_handle btrfs_join_transaction(struct btrfs_root root);
		struct btrfs_trans_handle btrfs_join_transaction_nolock(struct btrfs_root root);
		struct btrfs_trans_handle btrfs_attach_transaction(struct btrfs_root root);

Admin message