staging: rtl8723bs: convert tasklets to use new tasklet_setup() API (780664b6) · Commits · 戴 / test

In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by:

Romain Perier <romain.perier@gmail.com> Signed-off-by:

Allen Pais <apais@linux.microsoft.com> Link: https://lore.kernel.org/r/20200916061630.57717-1-allen.lkml@gmail.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -230,9 +230,10 @@ static inline bool pkt_exceeds_tail(struct recv_priv *precvpriv,
		return false;
		}

		static void rtl8723bs_recv_tasklet(unsigned long priv)
		static void rtl8723bs_recv_tasklet(struct tasklet_struct *t)
		{
		struct adapter *padapter;
		struct adapter *padapter = from_tasklet(padapter, t,
		recvpriv.recv_tasklet);
		struct hal_com_data *p_hal_data;
		struct recv_priv *precvpriv;
		struct recv_buf *precvbuf;
		@@ -244,7 +245,6 @@ static void rtl8723bs_recv_tasklet(unsigned long priv)
		_pkt *pkt_copy = NULL;
		u8 shift_sz = 0, rx_report_sz = 0;

		padapter = (struct adapter *)priv;
		p_hal_data = GET_HAL_DATA(padapter);
		precvpriv = &padapter->recvpriv;
		recv_buf_queue = &precvpriv->recv_buf_pending_queue;
		@@ -444,8 +444,7 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
		goto initbuferror;

		/* 3 2. init tasklet */
		tasklet_init(&precvpriv->recv_tasklet, rtl8723bs_recv_tasklet,
		(unsigned long)padapter);
		tasklet_setup(&precvpriv->recv_tasklet, rtl8723bs_recv_tasklet);

		goto exit;

Admin message