Commit 77f4025b authored Apr 16, 2009 by Linus Walleij Committed by Russell King Apr 16, 2009

[ARM] 5455/1: Fix IRQ noise from VIC code



The VIC code will attempt to perform som
default set_irq_chip() and set_irq_chip_data()
on all IRQs supported by the VIC, while the new
IRQ handling code strictly checks for the global
NR_IRQS to be respected also for these IRQs.

This patch will respect the interrupt mask passed
to the VIC driver and will prevent it from
attempting to call these functions on any unused
interrupts.

Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

parent 5e075cb5

arch/arm/common/vic.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -85,12 +85,11 @@ void __init vic_init(void __iomem *base, unsigned int irq_start,
		writel(32, base + VIC_PL190_DEF_VECT_ADDR);

		for (i = 0; i < 32; i++) {
		if (vic_sources & (1 << i)) {
		unsigned int irq = irq_start + i;

		set_irq_chip(irq, &vic_chip);
		set_irq_chip_data(irq, base);

		if (vic_sources & (1 << i)) {
		set_irq_handler(irq, handle_level_irq);
		set_irq_flags(irq, IRQF_VALID \| IRQF_PROBE);
		}

Admin message