Commit 77f1e0a5 authored by Jens Axboe's avatar Jens Axboe
Browse files

bfq: update internal depth state when queue depth changes 



A previous commit moved the shallow depth and BFQ depth map calculations
to be done at init time, moving it outside of the hotter IO path. This
potentially causes hangs if the users changes the depth of the scheduler
map, by writing to the 'nr_requests' sysfs file for that device.

Add a blk-mq-sched hook that allows blk-mq to inform the scheduler if
the depth changes, so that the scheduler can update its internal state.

Tested-by: default avatarKai Krakow <kai@kaishome.de>
Reported-by: default avatarPaolo Valente <paolo.valente@linaro.org>
Fixes: f0635b8a ("bfq: calculate shallow depths at init time")
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 917257da

block/bfq-iosched.c

+7 −1
Original line number Diff line number Diff line
@@ -5396,7 +5396,7 @@ static unsigned int bfq_update_depths(struct bfq_data *bfqd, 
	return min_shallow;

}



static int bfq_init_hctx(struct blk_mq_hw_ctx *hctx, unsigned int index)

static void bfq_depth_updated(struct blk_mq_hw_ctx *hctx)

{

	struct bfq_data *bfqd = hctx->queue->elevator->elevator_data;

	struct blk_mq_tags *tags = hctx->sched_tags;
@@ -5404,6 +5404,11 @@ static int bfq_init_hctx(struct blk_mq_hw_ctx *hctx, unsigned int index) 


	min_shallow = bfq_update_depths(bfqd, &tags->bitmap_tags);

	sbitmap_queue_min_shallow_depth(&tags->bitmap_tags, min_shallow);

}



static int bfq_init_hctx(struct blk_mq_hw_ctx *hctx, unsigned int index)

{

	bfq_depth_updated(hctx);

	return 0;

}
@@ -5826,6 +5831,7 @@ static struct elevator_type iosched_bfq_mq = { 
		.requests_merged	= bfq_requests_merged,

		.request_merged		= bfq_request_merged,

		.has_work		= bfq_has_work,

		.depth_updated		= bfq_depth_updated,

		.init_hctx		= bfq_init_hctx,

		.init_sched		= bfq_init_queue,

		.exit_sched		= bfq_exit_queue,

block/blk-mq.c

+2 −0
Original line number Diff line number Diff line
@@ -3135,6 +3135,8 @@ int blk_mq_update_nr_requests(struct request_queue *q, unsigned int nr) 
		}

		if (ret)

			break;

		if (q->elevator && q->elevator->type->ops.depth_updated)

			q->elevator->type->ops.depth_updated(hctx);

	}



	if (!ret)

include/linux/elevator.h

+1 −0
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ struct elevator_mq_ops { 
	void (*exit_sched)(struct elevator_queue *);

	int (*init_hctx)(struct blk_mq_hw_ctx *, unsigned int);

	void (*exit_hctx)(struct blk_mq_hw_ctx *, unsigned int);

	void (*depth_updated)(struct blk_mq_hw_ctx *);



	bool (*allow_merge)(struct request_queue *, struct request *, struct bio *);

	bool (*bio_merge)(struct blk_mq_hw_ctx *, struct bio *);

CRA Git | Maintained and supported by SUSTech CRA and CCSE