Commit 77ef033b authored May 04, 2017 by Michal Schmidt Committed by David S. Miller May 04, 2017

rtnetlink: NUL-terminate IFLA_PHYS_PORT_NAME string



IFLA_PHYS_PORT_NAME is a string attribute, so terminate it with \0.
Otherwise libnl3 fails to validate netlink messages with this attribute.
"ip -detail a" assumes too that the attribute is NUL-terminated when
printing it. It often was, due to padding.

I noticed this as libvirtd failing to start on a system with sfc driver
after upgrading it to Linux 4.11, i.e. when sfc added support for
phys_port_name.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2be0f264

net/core/rtnetlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1054,7 +1054,7 @@ static int rtnl_phys_port_name_fill(struct sk_buff skb, struct net_device dev)
		return err;
		}

		if (nla_put(skb, IFLA_PHYS_PORT_NAME, strlen(name), name))
		if (nla_put_string(skb, IFLA_PHYS_PORT_NAME, name))
		return -EMSGSIZE;

		return 0;

Admin message