Commit 77e4907f authored Sep 10, 2020 by Dan Carpenter Committed by Mika Westerberg Sep 10, 2020

thunderbolt: debugfs: Fix uninitialized return in counters_write()



If the first line is in an invalid format then the "ret" value is
uninitialized.  We should return -EINVAL instead.

Fixes: 54e41810 ("thunderbolt: Add debugfs interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

parent 54e41810

drivers/thunderbolt/debugfs.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -231,6 +231,7 @@ static ssize_t counters_write(struct file file, const char __user user_buf,
		char *line = buf;
		u32 val, offset;

		ret = -EINVAL;
		while (parse_line(&line, &offset, &val, 1, 4)) {
		ret = tb_port_write(port, &val, TB_CFG_COUNTERS,
		offset, 1);

Admin message