Commit 77d683f3 authored Dec 04, 2008 by Frederic Weisbecker Committed by Ingo Molnar Dec 05, 2008

tracing/ftrace: fix the check of ftrace_trace_task



Impact: fix default empty traces on function-graph-tracer

The actual ftrace_trace_task() checks if ftrace_pid_trace is allocated
and return 1 if it is true.
If it is NULL, it will check the bit of pid tracing flag for the current
task (which are not set by default).
So by default, a task is not traced.
Actually all tasks should be traced by default and filter_by_pid when
ftrace_pid_trace is allocated.

The appropriate condition should be to return 1 if filter_by_pid is
set.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Acke-dby: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent ff32504f

kernel/trace/trace.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -551,7 +551,7 @@ extern struct pid *ftrace_pid_trace;

		static inline int ftrace_trace_task(struct task_struct *task)
		{
		if (ftrace_pid_trace)
		if (!ftrace_pid_trace)
		return 1;

		return test_tsk_trace_trace(task);

Admin message