Commit 77d2a24b authored Jul 01, 2018 by Guenter Roeck Committed by Greg Kroah-Hartman Jul 07, 2018

kobject: Replace strncpy with memcpy



gcc 8.1.0 complains:

lib/kobject.c:128:3: warning:
	'strncpy' output truncated before terminating nul copying as many
	bytes from a string as its length [-Wstringop-truncation]
lib/kobject.c: In function 'kobject_get_path':
lib/kobject.c:125:13: note: length computed here

Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 448a5a55

lib/kobject.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -125,7 +125,7 @@ static void fill_kobj_path(struct kobject kobj, char path, int length)
		int cur = strlen(kobject_name(parent));
		/* back up enough to print this name with '/' */
		length -= cur;
		strncpy(path + length, kobject_name(parent), cur);
		memcpy(path + length, kobject_name(parent), cur);
		*(path + --length) = '/';
		}

Admin message