Commit 77c0c973 authored Apr 30, 2016 by Vitaly Kuznetsov Committed by Greg Kroah-Hartman May 01, 2016

Drivers: hv: balloon: don't crash when memory is added in non-sorted order



When we iterate through all HA regions in handle_pg_range() we have an
assumption that all these regions are sorted in the list and the
'start_pfn >= has->end_pfn' check is enough to find the proper region.
Unfortunately it's not the case with WS2016 where host can hot-add regions
in a different order. We end up modifying the wrong HA region and crashing
later on pages online. Modify the check to make sure we found the region
we were searching for while iterating. Fix the same check in pfn_covered()
as well.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent cd95aad5

drivers/hv/hv_balloon.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -714,7 +714,7 @@ static bool pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
		* If the pfn range we are dealing with is not in the current
		* "hot add block", move on.
		*/
		if ((start_pfn >= has->end_pfn))
		if (start_pfn < has->start_pfn \|\| start_pfn >= has->end_pfn)
		continue;
		/*
		* If the current hot add-request extends beyond
		@@ -768,7 +768,7 @@ static unsigned long handle_pg_range(unsigned long pg_start,
		* If the pfn range we are dealing with is not in the current
		* "hot add block", move on.
		*/
		if ((start_pfn >= has->end_pfn))
		if (start_pfn < has->start_pfn \|\| start_pfn >= has->end_pfn)
		continue;

		old_covered_state = has->covered_end_pfn;

Admin message