memory: tegra: Ensure timing control debug features are disabled (77b7182f) · Commits · 戴 / test

Timing control debug features should be disabled at a boot time, but you never now and hence it's better to disable them explicitly because some of those features are crucial for the driver to do a proper thing. Acked-by:

Peter De Schrijver <pdeschrijver@nvidia.com> Signed-off-by:

Dmitry Osipenko <digetx@gmail.com> Signed-off-by:

Thierry Reding <treding@nvidia.com>

drivers/memory/tegra/mc.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -667,6 +667,9 @@ static int tegra_mc_probe(struct platform_device *pdev)
		} else
		#endif
		{
		/* ensure that debug features are disabled */
		mc_writel(mc, 0x00000000, MC_TIMING_CONTROL_DBG);

		err = tegra_mc_setup_latency_allowance(mc);
		if (err < 0) {
		dev_err(&pdev->dev,

drivers/memory/tegra/mc.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -30,6 +30,8 @@
		#define MC_EMEM_ARB_OVERRIDE 0xe8
		#define MC_EMEM_ARB_OVERRIDE_EACK_MASK 0x3

		#define MC_TIMING_CONTROL_DBG 0xf8

		#define MC_TIMING_CONTROL 0xfc
		#define MC_TIMING_UPDATE BIT(0)

Admin message