Commit 77a80692 authored by Yuyang Du's avatar Yuyang Du Committed by Ingo Molnar
Browse files

locking/lockdep: Avoid constant checks in __bfs by using offset reference 



In search of a dependency in the lock graph, there is contant checks for
forward or backward search. Directly reference the field offset of the
struct that differentiates the type of search to avoid those checks.

No functional change.

Signed-off-by: default avatarYuyang Du <duyuyang@gmail.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: bvanassche@acm.org
Cc: frederic@kernel.org
Cc: ming.lei@redhat.com
Cc: will.deacon@arm.com
Link: https://lkml.kernel.org/r/20190506081939.74287-15-duyuyang@gmail.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent c1661325

kernel/locking/lockdep.c

+21 −12
Original line number Diff line number Diff line
@@ -1367,11 +1367,25 @@ static inline int get_lock_depth(struct lock_list *child) 
	return depth;

}



/*

 * Return the forward or backward dependency list.

 *

 * @lock:   the lock_list to get its class's dependency list

 * @offset: the offset to struct lock_class to determine whether it is

 *          locks_after or locks_before

 */

static inline struct list_head *get_dep_list(struct lock_list *lock, int offset)

{

	void *lock_class = lock->class;



	return lock_class + offset;

}



static int __bfs(struct lock_list *source_entry,

		 void *data,

		 int (*match)(struct lock_list *entry, void *data),

		 struct lock_list **target_entry,

		 int forward)

		 int offset)

{

	struct lock_list *entry;

	struct lock_list *lock;
@@ -1385,11 +1399,7 @@ static int __bfs(struct lock_list *source_entry, 
		goto exit;

	}



	if (forward)

		head = &source_entry->class->locks_after;

	else

		head = &source_entry->class->locks_before;



	head = get_dep_list(source_entry, offset);

	if (list_empty(head))

		goto exit;
@@ -1403,10 +1413,7 @@ static int __bfs(struct lock_list *source_entry, 
			goto exit;

		}



		if (forward)

			head = &lock->class->locks_after;

		else

			head = &lock->class->locks_before;

		head = get_dep_list(lock, offset);



		DEBUG_LOCKS_WARN_ON(!irqs_disabled());
@@ -1439,7 +1446,8 @@ static inline int __bfs_forwards(struct lock_list *src_entry, 
			int (*match)(struct lock_list *entry, void *data),

			struct lock_list **target_entry)

{

	return __bfs(src_entry, data, match, target_entry, 1);

	return __bfs(src_entry, data, match, target_entry,

		     offsetof(struct lock_class, locks_after));



}
@@ -1448,7 +1456,8 @@ static inline int __bfs_backwards(struct lock_list *src_entry, 
			int (*match)(struct lock_list *entry, void *data),

			struct lock_list **target_entry)

{

	return __bfs(src_entry, data, match, target_entry, 0);

	return __bfs(src_entry, data, match, target_entry,

		     offsetof(struct lock_class, locks_before));



}

CRA Git | Maintained and supported by SUSTech CRA and CCSE