Commit 77970693 authored Apr 05, 2011 by Jeff Layton Committed by Steve French Apr 12, 2011

cifs: check for private_data before trying to put it



cifs_close doesn't check that the filp->private_data is non-NULL before
trying to put it. That can cause an oops in certain error conditions
that can occur on open or lookup before the private_data is set.

Reported-by: Ben Greear <greearb@candelatech.com>
CC: Stable <stable@kernel.org>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent a6360dd3

fs/cifs/file.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -575,8 +575,10 @@ reopen_error_exit:

		int cifs_close(struct inode inode, struct file file)
		{
		if (file->private_data != NULL) {
		cifsFileInfo_put(file->private_data);
		file->private_data = NULL;
		}

		/* return code from the ->release op is always ignored */
		return 0;

Admin message