Commit 77867fff authored Jul 28, 2009 by Dan Williams

ioat: fix type mismatch for ->dmacount



->dmacount tracks the sequence number of active descriptors.  It is
written to the DMACOUNT register to update the channel's view of pending
descriptors in the chain.  The register is 16-bits so ->dmacount should
be unsigned and 16-bit as well.  Also modify ->desccount to maintain
alignment.

This was never a problem in practice because we never compared dmacount
values, but this is a bug waiting to happen.

Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent f2427e27

drivers/dma/ioat/dma.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -102,8 +102,8 @@ struct ioat_dma_chan {
		struct delayed_work work;

		int pending;
		int dmacount;
		int desccount;
		u16 dmacount;
		u16 desccount;

		struct ioatdma_device *device;
		struct dma_chan common;

Admin message