mtd: rawnand: remove unecessary checking if dmac is NULL (777260a5) · Commits · 戴 / test

Remove unecessary checking if dmac is NULL. If Cadence nand controller driver uses DMA engine then cdns_ctrl->dmac cannot be NULL. It is verified during driver initialization. If Cadence nand controller driver does not use DMA engine then CPU IO read/write are executed instead of slave DMA transfer. In that case cdns_ctrl->dmac is not used at all. Reported-by:

kbuild test robot <lkp@intel.com> Reported-by:

Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:

Piotr Sroka <piotrs@cadence.com> Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com>

drivers/mtd/nand/raw/cadence-nand-controller.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1886,7 +1886,7 @@ static int cadence_nand_read_buf(struct cdns_nand_ctrl *cdns_ctrl,
		return 0;
		}

		if (cdns_ctrl->dmac && cadence_nand_dma_buf_ok(cdns_ctrl, buf, len)) {
		if (cadence_nand_dma_buf_ok(cdns_ctrl, buf, len)) {
		status = cadence_nand_slave_dma_transfer(cdns_ctrl, buf,
		cdns_ctrl->io.dma,
		len, DMA_FROM_DEVICE);
		@@ -1940,7 +1940,7 @@ static int cadence_nand_write_buf(struct cdns_nand_ctrl *cdns_ctrl,
		return 0;
		}

		if (cdns_ctrl->dmac && cadence_nand_dma_buf_ok(cdns_ctrl, buf, len)) {
		if (cadence_nand_dma_buf_ok(cdns_ctrl, buf, len)) {
		status = cadence_nand_slave_dma_transfer(cdns_ctrl, (void *)buf,
		cdns_ctrl->io.dma,
		len, DMA_TO_DEVICE);

Admin message