Commit 776cdc11 authored Mar 28, 2012 by Guenter Roeck Committed by Guenter Roeck Apr 09, 2012

hwmon: (acpi_power_meter) Fix compiler warning seen in some configurations

In some configurations, BUG() does not result in an endless loop but returns
to the caller. This results in the following compiler warning:

drivers/hwmon/acpi_power_meter.c: In function 'show_str':
drivers/hwmon/acpi_power_meter.c:380: warning: 'val' may be used uninitialized in this function

Fix the warning by setting val to an empty string after BUG().

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Robert Coulson <robert.coulson@ericsson.com>

parent 8528e07e

drivers/hwmon/acpi_power_meter.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -391,6 +391,7 @@ static ssize_t show_str(struct device *dev,
		break;
		default:
		BUG();
		val = "";
		}

		return sprintf(buf, "%s\n", val);

Admin message