Commit 774cb499 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf tools: Fix 'disabled' attribute config for record command 



Currently the record command sets all events initially as disabled.

There's non conditional perf_evlist__enable call, that enables all
events before we exec tracee program. That actually screws whole
enable_on_exec logic, because the event is enabled before the traced
program got executed.

What we actually want is:

1) For any type of traced program:
  - all independent events and group leaders are disabled
  - all group members are enabled

   Group members are ruled by group leaders. They need to
   be enabled, because the group scheduling relies on that.

2) For traced programs executed by perf:
   - all independent events and group leaders have
     enable_on_exec set
   - we don't specifically enable or disable any event during
     the record command

   Independent events and group leaders are initially disabled
   and get enabled by exec. Group members are ruled by group
   leaders as stated in 1).

3) For traced programs attached by perf (pid/tid):
   - we specifically enable or disable all events during
     the record command

   When attaching events to already running traced we
   enable/disable events specifically, as there's no
   initial traced exec call.

Fixing appropriate perf_event_attr test case to cover this change.

Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1352741644-16809-3-git-send-email-jolsa@redhat.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent cac21425

tools/perf/builtin-record.c

+13 −2
Original line number Diff line number Diff line
@@ -701,6 +701,12 @@ static int __cmd_record(struct perf_record *rec, int argc, const char **argv) 
		}

	}



	/*

	 * When perf is starting the traced process, all the events

	 * (apart from group members) have enable_on_exec=1 set,

	 * so don't spoil it by prematurely enabling them.

	 */

	if (!perf_target__none(&opts->target))

		perf_evlist__enable(evsel_list);



	/*
@@ -724,7 +730,12 @@ static int __cmd_record(struct perf_record *rec, int argc, const char **argv) 
			waking++;

		}



		if (done)

		/*

		 * When perf is starting the traced process, at the end events

		 * die with the process and we wait for that. Thus no need to

		 * disable events in this case.

		 */

		if (done && !perf_target__none(&opts->target))

			perf_evlist__disable(evsel_list);

	}

tools/perf/tests/attr/test-record-group

+1 −0
Original line number Diff line number Diff line
@@ -15,3 +15,4 @@ sample_type=327 
mmap=0

comm=0

enable_on_exec=0

disabled=0

tools/perf/tests/attr/test-record-group1

+1 −0
Original line number Diff line number Diff line
@@ -16,3 +16,4 @@ sample_type=327 
mmap=0

comm=0

enable_on_exec=0

disabled=0

tools/perf/util/evsel.c

+41 −1
Original line number Diff line number Diff line
@@ -404,13 +404,40 @@ const char *perf_evsel__name(struct perf_evsel *evsel) 
	return evsel->name ?: "unknown";

}



/*

 * The enable_on_exec/disabled value strategy:

 *

 *  1) For any type of traced program:

 *    - all independent events and group leaders are disabled

 *    - all group members are enabled

 *

 *     Group members are ruled by group leaders. They need to

 *     be enabled, because the group scheduling relies on that.

 *

 *  2) For traced programs executed by perf:

 *     - all independent events and group leaders have

 *       enable_on_exec set

 *     - we don't specifically enable or disable any event during

 *       the record command

 *

 *     Independent events and group leaders are initially disabled

 *     and get enabled by exec. Group members are ruled by group

 *     leaders as stated in 1).

 *

 *  3) For traced programs attached by perf (pid/tid):

 *     - we specifically enable or disable all events during

 *       the record command

 *

 *     When attaching events to already running traced we

 *     enable/disable events specifically, as there's no

 *     initial traced exec call.

 */

void perf_evsel__config(struct perf_evsel *evsel,

			struct perf_record_opts *opts)

{

	struct perf_event_attr *attr = &evsel->attr;

	int track = !evsel->idx; /* only the first counter needs these */



	attr->disabled = 1;

	attr->sample_id_all = opts->sample_id_all_missing ? 0 : 1;

	attr->inherit	    = !opts->no_inherit;

	attr->read_format   = PERF_FORMAT_TOTAL_TIME_ENABLED |
@@ -486,6 +513,19 @@ void perf_evsel__config(struct perf_evsel *evsel, 
	attr->mmap = track;

	attr->comm = track;



	/*

	 * XXX see the function comment above

	 *

	 * Disabling only independent events or group leaders,

	 * keeping group members enabled.

	 */

	if (!evsel->leader)

		attr->disabled = 1;



	/*

	 * Setting enable_on_exec for independent events and

	 * group leaders for traced executed by perf.

	 */

	if (perf_target__none(&opts->target) && (!evsel->leader))

		attr->enable_on_exec = 1;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE