jbd2: mark file-local functions as static (7747e6d0) · Commits · 戴 / test

Mark functions as static in jbd2/journal.c because they are not used outside this file. This eliminates the following warning in jbd2/journal.c: fs/jbd2/journal.c:125:5: warning: no previous prototype for ‘jbd2_verify_csum_type’ [-Wmissing-prototypes] fs/jbd2/journal.c:146:5: warning: no previous prototype for ‘jbd2_superblock_csum_verify’ [-Wmissing-prototypes] fs/jbd2/journal.c:154:6: warning: no previous prototype for ‘jbd2_superblock_csum_set’ [-Wmissing-prototypes] Signed-off-by:

Rashika Kheria <rashika.kheria@gmail.com> Signed-off-by:

"Theodore Ts'o" <tytso@mit.edu> Reviewed-by:

Josh Triplett <josh@joshtriplett.org> Reviewed-by:

Darrick J. Wong <darrick.wong@oracle.com>

fs/jbd2/journal.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -122,7 +122,7 @@ EXPORT_SYMBOL(__jbd2_debug);
		#endif

		/* Checksumming functions */
		int jbd2_verify_csum_type(journal_t j, journal_superblock_t sb)
		static int jbd2_verify_csum_type(journal_t j, journal_superblock_t sb)
		{
		if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
		return 1;
		@@ -143,7 +143,7 @@ static __be32 jbd2_superblock_csum(journal_t j, journal_superblock_t sb)
		return cpu_to_be32(csum);
		}

		int jbd2_superblock_csum_verify(journal_t j, journal_superblock_t sb)
		static int jbd2_superblock_csum_verify(journal_t j, journal_superblock_t sb)
		{
		if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
		return 1;
		@@ -151,7 +151,7 @@ int jbd2_superblock_csum_verify(journal_t j, journal_superblock_t sb)
		return sb->s_checksum == jbd2_superblock_csum(j, sb);
		}

		void jbd2_superblock_csum_set(journal_t j, journal_superblock_t sb)
		static void jbd2_superblock_csum_set(journal_t j, journal_superblock_t sb)
		{
		if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
		return;

Admin message