Commit 7726fb53 authored Sep 24, 2019 by Xiaoming Ni Committed by Greg Kroah-Hartman Oct 04, 2019

tty:n_gsm.c: destroy port by tty_port_destroy()



According to the comment of tty_port_destroy():
    When a port was initialized using tty_port_init, one has to destroy
    the port by tty_port_destroy();

tty_port_init() is called in gsm_dlci_alloc()
so tty_port_destroy() needs to be called in gsm_dlci_free()

Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
Link: https://lore.kernel.org/r/1569317156-45850-1-git-send-email-nixiaoming@huawei.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 530c4ba3

drivers/tty/n_gsm.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1681,6 +1681,7 @@ static void gsm_dlci_free(struct tty_port *port)

		del_timer_sync(&dlci->t1);
		dlci->gsm->dlci[dlci->addr] = NULL;
		tty_port_destroy(&dlci->port);
		kfifo_free(dlci->fifo);
		while ((dlci->skb = skb_dequeue(&dlci->skb_list)))
		dev_kfree_skb(dlci->skb);

Admin message