Commit 7722b799 authored by Lee Jones's avatar Lee Jones
Browse files

ab8500_charger: Reorder obtainment of platform specific battery management data 



Now that we always pass platform specific battery management data
through platform_data instead of obtaining it via different means
depending the way be boot the system (DT or ATAGs); we need to
re-jiggle the way we acquire it in the driver start-up functions.
Now it is wrong for it to be missing, but we still allow Device
Tree code to fiddle with it once we've confirmed it's there.

Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 95820245

drivers/power/ab8500_charger.c

+15 −16
Original line number Diff line number Diff line
@@ -2636,6 +2636,7 @@ static char *supply_interface[] = { 
static int __devinit ab8500_charger_probe(struct platform_device *pdev)

{

	struct device_node *np = pdev->dev.of_node;

	struct abx500_bm_data *plat = pdev->dev.platform_data;

	struct ab8500_charger *di;

	int irq, i, charger_status, ret = 0;
@@ -2644,24 +2645,22 @@ static int __devinit ab8500_charger_probe(struct platform_device *pdev) 
		dev_err(&pdev->dev, "%s no mem for ab8500_charger\n", __func__);

		return -ENOMEM;

	}

	di->bm = pdev->mfd_cell->platform_data;

	if (!di->bm) {



	if (!plat) {

		dev_err(&pdev->dev, "no battery management data supplied\n");

		return -EINVAL;

	}

	di->bm = plat;



	if (np) {

		ret = ab8500_bm_of_probe(&pdev->dev, np, di->bm);

		if (ret) {

				dev_err(&pdev->dev,

					"failed to get battery information\n");

			dev_err(&pdev->dev, "failed to get battery information\n");

			return ret;

		}

		di->autopower_cfg = of_property_read_bool(np, "autopower_cfg");

		} else {

			dev_err(&pdev->dev, "missing dt node for ab8500_charger\n");

			return -EINVAL;

		}

	} else {

		dev_info(&pdev->dev, "falling back to legacy platform data\n");

	} else

		di->autopower_cfg = false;

	}



	/* get parent data */

	di->dev = &pdev->dev;

CRA Git | Maintained and supported by SUSTech CRA and CCSE