Commit 77190e1f authored by Yunlong Song's avatar Yunlong Song Committed by Jaegeuk Kim
Browse files

f2fs: remove unnecessary condition check for write_checkpoint in f2fs_gc 



Since has_not_enough_free_secs(sbi, 0, 0) must be true if has_not_enough_
free_secs(sbi, sec_freed, 0) is true, write_checkpoint is sure to execute in
both conditions.

Signed-off-by: default avatarYunlong Song <yunlong.song@huawei.com>
Reviewed-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 92592285

fs/f2fs/gc.c

+3 −9
Original line number Diff line number Diff line
@@ -958,15 +958,9 @@ gc_more: 
		 * enough free sections, we should flush dent/node blocks and do

		 * garbage collections.

		 */

		if (dirty_segments(sbi) || prefree_segments(sbi)) {

		ret = write_checkpoint(sbi, &cpc);

		if (ret)

			goto stop;

		} else if (has_not_enough_free_secs(sbi, 0, 0)) {

			ret = write_checkpoint(sbi, &cpc);

			if (ret)

				goto stop;

		}

	} else if (gc_type == BG_GC && !background) {

		/* f2fs_balance_fs doesn't need to do BG_GC in critical path. */

		goto stop;

CRA Git | Maintained and supported by SUSTech CRA and CCSE