Commit 77142a61 authored Apr 24, 2018 by Mike Looijmans Committed by Sebastian Reichel Apr 25, 2018

gpio-poweroff: Use gpiod_set_value_cansleep

The power-off call is done in a context that must be able to sleep, so
use gpiod_set_value_cansleep instead of the atomic gpiod_set_value call.

This fixes a kernel warning at shutdown when the gpio is controlled
through an IO expander for example.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

parent 6d08b06e

drivers/power/reset/gpio-poweroff.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -35,11 +35,11 @@ static void gpio_poweroff_do_poweroff(void)
		gpiod_direction_output(reset_gpio, 1);
		mdelay(100);
		/* drive inactive, also active->inactive edge */
		gpiod_set_value(reset_gpio, 0);
		gpiod_set_value_cansleep(reset_gpio, 0);
		mdelay(100);

		/* drive it active, also inactive->active edge */
		gpiod_set_value(reset_gpio, 1);
		gpiod_set_value_cansleep(reset_gpio, 1);

		/* give it some time */
		mdelay(timeout);