Commit 76f2db08 authored Apr 25, 2019 by Jonas Karlman Committed by Mauro Carvalho Chehab May 15, 2019

media: rockchip/vpu: Do not request id 0 for our video device



Pass -1 to video_register_device() to let the core assign the first
free id instead of trying to get id 0.
In practice it doesn't make a difference since video_register_device()
is not strict about id requests and will anyway pick the first free id
starting at the id passed in argument, and passing -1 has the same
effect as passing 0. But let's comply with the API doc and pass -1
here.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 1199fa8c

drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -352,7 +352,7 @@ static int rockchip_vpu_video_device_register(struct rockchip_vpu_dev *vpu)
		vpu->vfd_enc = vfd;
		video_set_drvdata(vfd, vpu);

		ret = video_register_device(vfd, VFL_TYPE_GRABBER, 0);
		ret = video_register_device(vfd, VFL_TYPE_GRABBER, -1);
		if (ret) {
		v4l2_err(&vpu->v4l2_dev, "Failed to register video device\n");
		goto err_free_dev;

Admin message