Commit 76e4c327 authored Jul 22, 2016 by Markus Elfring Committed by Daniel Vetter Jul 22, 2016

GPU-DRM-OMAP: Delete unnecessary checks before two function calls



The following functions test whether their argument is NULL and then
return immediately.
* backlight_device_unregister
* drm_gem_object_unreference_unlocked

Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/72ff4670-4f3d-c7ed-4f37-e49f2bbc7aba@users.sourceforge.net

parent e8d3ef02

drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1284,7 +1284,6 @@ static int dsicm_probe(struct platform_device *pdev)
		return 0;

		err_sysfs_create:
		if (bldev != NULL)
		backlight_device_unregister(bldev);
		err_bl:
		destroy_workqueue(ddata->workqueue);

drivers/gpu/drm/omapdrm/omap_fb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -115,7 +115,7 @@ static void omap_framebuffer_destroy(struct drm_framebuffer *fb)

		for (i = 0; i < n; i++) {
		struct plane *plane = &omap_fb->planes[i];
		if (plane->bo)

		drm_gem_object_unreference_unlocked(plane->bo);
		}

Admin message