Commit 76d10256 authored Jul 20, 2020 by Kan Liang Committed by Ingo Molnar Aug 07, 2020

x86/fpu/xstate: Fix an xstate size check warning with architectural LBRs

An xstate size check warning is triggered on machines which support
Architectural LBRs.

XSAVE consistency problem, dumping leaves
WARNING: CPU: 0 PID: 0 at arch/x86/kernel/fpu/xstate.c:649 fpu__init_system_xstate+0x4d4/0xd0e
Modules linked in:
CPU: 0 PID: 0 Comm: swapper Not tainted intel-arch_lbr+
RIP: 0010:fpu__init_system_xstate+0x4d4/0xd0e

The xstate size check routine, init_xstate_size(), compares the size
retrieved from the hardware with the size of task->fpu, which is
calculated by the software.

The size from the hardware is the total size of the enabled xstates in
XCR0 | IA32_XSS. Architectural LBR state is a dynamic supervisor
feature, which sets the corresponding bit in the IA32_XSS at boot time.
The size from the hardware includes the size of the Architectural LBR
state.

However, a dynamic supervisor feature doesn't allocate a buffer in the
task->fpu. The size of task->fpu doesn't include the size of the
Architectural LBR state. The mismatch will trigger the warning.

Three options as below were considered to fix the issue:

- Correct the size from the hardware by subtracting the size of the
dynamic supervisor features.
The purpose of the check is to compare the size CPU told with the size
of the XSAVE buffer, which is calculated by the software. If the
software mucks with the number from hardware, it removes the value of
the check.
This option is not a good option.

- Prevent the hardware from counting the size of the dynamic supervisor
feature by temporarily removing the corresponding bits in IA32_XSS.
Two extra MSR writes are required to flip the IA32_XSS. The option is
not pretty, but it is workable. The check is only called once at early
boot time. The synchronization or context-switching doesn't need to be
worried.
This option is implemented here.

- Remove the check entirely, because the check hasn't found any real
problems. The option may be an alternative as option 2.
This option is not implemented here.

Add a new function, get_xsaves_size_no_dynamic(), which retrieves the
total size without the dynamic supervisor features from the hardware.
The size will be used to compare with the size of task->fpu.

Fixes: f0dccc9d ("x86/fpu/xstate: Support dynamic supervisor feature for LBR")
Reported-by: Chang S. Bae <chang.seok.bae@intel.com>
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Dave Hansen <dave.hansen@intel.com>
Link: https://lore.kernel.org/r/1595253051-75374-1-git-send-email-kan.liang@linux.intel.com

parent 52416ffc

arch/x86/kernel/fpu/xstate.c

+32 −1

Original line number	Diff line number	Diff line
		@@ -611,6 +611,10 @@ static void check_xstate_against_struct(int nr)
		* This essentially double-checks what the cpu told us about
		* how large the XSAVE buffer needs to be. We are recalculating
		* it to be safe.
		*
		* Dynamic XSAVE features allocate their own buffers and are not
		* covered by these checks. Only the size of the buffer for task->fpu
		* is checked here.
		*/
		static void do_extra_xstate_size_checks(void)
		{
		@@ -673,6 +677,33 @@ static unsigned int __init get_xsaves_size(void)
		return ebx;
		}

		/*
		* Get the total size of the enabled xstates without the dynamic supervisor
		* features.
		*/
		static unsigned int __init get_xsaves_size_no_dynamic(void)
		{
		u64 mask = xfeatures_mask_dynamic();
		unsigned int size;

		if (!mask)
		return get_xsaves_size();

		/* Disable dynamic features. */
		wrmsrl(MSR_IA32_XSS, xfeatures_mask_supervisor());

		/*
		* Ask the hardware what size is required of the buffer.
		* This is the size required for the task->fpu buffer.
		*/
		size = get_xsaves_size();

		/* Re-enable dynamic features so XSAVES will work on them again. */
		wrmsrl(MSR_IA32_XSS, xfeatures_mask_supervisor() \| mask);

		return size;
		}

		static unsigned int __init get_xsave_size(void)
		{
		unsigned int eax, ebx, ecx, edx;
		@@ -710,7 +741,7 @@ static int __init init_xstate_size(void)
		xsave_size = get_xsave_size();

		if (boot_cpu_has(X86_FEATURE_XSAVES))
		possible_xstate_size = get_xsaves_size();
		possible_xstate_size = get_xsaves_size_no_dynamic();
		else
		possible_xstate_size = xsave_size;

Admin message