Commit 76b6159b authored by Al Viro's avatar Al Viro
Browse files

[PATCH] fix handling of st_nlink on procfs root 



1) it should use nr_processes(), not nr_threads; otherwise we are getting
very confused find(1) and friends, among other things.
2) better do that at stat() time than at every damn lookup in procfs root.

Patch had been sitting in FC4 kernels for many months now...

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent e30809fd

fs/proc/inode.c

+0 −4
Original line number Diff line number Diff line
@@ -204,10 +204,6 @@ int proc_fill_super(struct super_block *s, void *data, int silent) 
	root_inode = proc_get_inode(s, PROC_ROOT_INO, &proc_root);

	if (!root_inode)

		goto out_no_root;

	/*

	 * Fixup the root inode's nlink value

	 */

	root_inode->i_nlink += nr_processes();

	root_inode->i_uid = 0;

	root_inode->i_gid = 0;

	s->s_root = d_alloc_root(root_inode);

fs/proc/root.c

+9 −8
Original line number Diff line number Diff line
@@ -80,16 +80,16 @@ void __init proc_root_init(void) 
	proc_bus = proc_mkdir("bus", NULL);

}



static struct dentry *proc_root_lookup(struct inode * dir, struct dentry * dentry, struct nameidata *nd)

static int proc_root_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat

)

{

	/*

	 * nr_threads is actually protected by the tasklist_lock;

	 * however, it's conventional to do reads, especially for

	 * reporting, without any locking whatsoever.

	 */

	if (dir->i_ino == PROC_ROOT_INO) /* check for safety... */

		dir->i_nlink = proc_root.nlink + nr_threads;

	generic_fillattr(dentry->d_inode, stat);

	stat->nlink = proc_root.nlink + nr_processes();

	return 0;

}



static struct dentry *proc_root_lookup(struct inode * dir, struct dentry * dentry, struct nameidata *nd)

{

	if (!proc_lookup(dir, dentry, nd)) {

		return NULL;

	}
@@ -134,6 +134,7 @@ static struct file_operations proc_root_operations = { 
 */

static struct inode_operations proc_root_inode_operations = {

	.lookup		= proc_root_lookup,

	.getattr	= proc_root_getattr,

};



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE