Commit 76acb5ee authored by Andrzej Hajda's avatar Andrzej Hajda Committed by Greg Kroah-Hartman
Browse files

drm/bridge: lvds-codec: simplify error handling 



Using dev_err_probe code has following advantages:
- shorter code,
- recorded defer probe reason for debugging,
- uniform error code logging.

Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Reviewed-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Link: https://lore.kernel.org/r/20200713144324.23654-5-a.hajda@samsung.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a60294d2

drivers/gpu/drm/bridge/lvds-codec.c

+3 −7
Original line number Diff line number Diff line
@@ -71,13 +71,9 @@ static int lvds_codec_probe(struct platform_device *pdev) 
	lvds_codec->connector_type = (uintptr_t)of_device_get_match_data(dev);

	lvds_codec->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown",

							     GPIOD_OUT_HIGH);

	if (IS_ERR(lvds_codec->powerdown_gpio)) {

		int err = PTR_ERR(lvds_codec->powerdown_gpio);



		if (err != -EPROBE_DEFER)

			dev_err(dev, "powerdown GPIO failure: %d\n", err);

		return err;

	}

	if (IS_ERR(lvds_codec->powerdown_gpio))

		return dev_err_probe(dev, PTR_ERR(lvds_codec->powerdown_gpio),

				     "powerdown GPIO failure\n");



	/* Locate the panel DT node. */

	panel_node = of_graph_get_remote_node(dev->of_node, 1, 0);

CRA Git | Maintained and supported by SUSTech CRA and CCSE