Commit 76a86f9d authored by Jens Axboe's avatar Jens Axboe
Browse files

block: remove REQ_ATOM_POLL_SLEPT 



We don't need this to be an atomic flag, it can be a regular
flag. We either end up on the same CPU for the polling, in which
case the state is sane, or we did the sleep which would imply
the needed barrier to ensure we see the right state.

Reviewed-by: default avatarBart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: default avatarOmar Sandoval <osandov@fb.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 5d75d3f2

block/blk-mq-debugfs.c

+1 −1
Original line number Diff line number Diff line
@@ -290,13 +290,13 @@ static const char *const rqf_name[] = { 
	RQF_NAME(SPECIAL_PAYLOAD),

	RQF_NAME(ZONE_WRITE_LOCKED),

	RQF_NAME(MQ_TIMEOUT_EXPIRED),

	RQF_NAME(MQ_POLL_SLEPT),

};

#undef RQF_NAME



#define RQAF_NAME(name) [REQ_ATOM_##name] = #name

static const char *const rqaf_name[] = {

	RQAF_NAME(COMPLETE),

	RQAF_NAME(POLL_SLEPT),

};

#undef RQAF_NAME

block/blk-mq.c

+2 −3
Original line number Diff line number Diff line
@@ -483,7 +483,6 @@ void blk_mq_free_request(struct request *rq) 
		blk_put_rl(blk_rq_rl(rq));



	blk_mq_rq_update_state(rq, MQ_RQ_IDLE);

	clear_bit(REQ_ATOM_POLL_SLEPT, &rq->atomic_flags);

	if (rq->tag != -1)

		blk_mq_put_tag(hctx, hctx->tags, ctx, rq->tag);

	if (sched_tag != -1)
@@ -2976,7 +2975,7 @@ static bool blk_mq_poll_hybrid_sleep(struct request_queue *q, 
	unsigned int nsecs;

	ktime_t kt;



	if (test_bit(REQ_ATOM_POLL_SLEPT, &rq->atomic_flags))

	if (rq->rq_flags & RQF_MQ_POLL_SLEPT)

		return false;



	/*
@@ -2996,7 +2995,7 @@ static bool blk_mq_poll_hybrid_sleep(struct request_queue *q, 
	if (!nsecs)

		return false;



	set_bit(REQ_ATOM_POLL_SLEPT, &rq->atomic_flags);

	rq->rq_flags |= RQF_MQ_POLL_SLEPT;



	/*

	 * This will be replaced with the stats tracking code, using

block/blk.h

+0 −2
Original line number Diff line number Diff line
@@ -124,8 +124,6 @@ void blk_account_io_done(struct request *req); 
 */

enum rq_atomic_flags {

	REQ_ATOM_COMPLETE = 0,



	REQ_ATOM_POLL_SLEPT,

};



/*

include/linux/blkdev.h

+2 −0
Original line number Diff line number Diff line
@@ -127,6 +127,8 @@ typedef __u32 __bitwise req_flags_t; 
#define RQF_ZONE_WRITE_LOCKED	((__force req_flags_t)(1 << 19))

/* timeout is expired */

#define RQF_MQ_TIMEOUT_EXPIRED	((__force req_flags_t)(1 << 20))

/* already slept for hybrid poll */

#define RQF_MQ_POLL_SLEPT	((__force req_flags_t)(1 << 21))



/* flags that prevent us from merging requests: */

#define RQF_NOMERGE_FLAGS \

CRA Git | Maintained and supported by SUSTech CRA and CCSE