Commit 76a57db4 authored by Christophe Fergeau's avatar Christophe Fergeau Committed by Gerd Hoffmann
Browse files

qxl: No need for NULL check before calling qxl_bo_unref() 



qxl_bo_unref() is already performing a NULL check.

Signed-off-by: default avatarChristophe Fergeau <cfergeau@redhat.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20181120162004.22807-1-cfergeau@redhat.com


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent a071a8ff

drivers/gpu/drm/qxl/qxl_display.c

+1 −3
Original line number Diff line number Diff line
@@ -670,9 +670,7 @@ static void qxl_cursor_atomic_update(struct drm_plane *plane, 
	qxl_push_cursor_ring_release(qdev, release, QXL_CMD_CURSOR, false);

	qxl_release_fence_buffer_objects(release);



	if (old_cursor_bo)

	qxl_bo_unref(&old_cursor_bo);



	qxl_bo_unref(&cursor_bo);



	return;

drivers/gpu/drm/qxl/qxl_draw.c

+1 −2
Original line number Diff line number Diff line
@@ -247,7 +247,6 @@ void qxl_draw_opaque_fb(const struct qxl_fb_image *qxl_fb_image, 
	qxl_release_fence_buffer_objects(release);



out_free_palette:

	if (palette_bo)

	qxl_bo_unref(&palette_bo);

out_free_image:

	qxl_image_free_objects(qdev, dimage);

drivers/gpu/drm/qxl/qxl_kms.c

+2 −4
Original line number Diff line number Diff line
@@ -313,9 +313,7 @@ error: 


void qxl_device_fini(struct qxl_device *qdev)

{

	if (qdev->current_release_bo[0])

	qxl_bo_unref(&qdev->current_release_bo[0]);

	if (qdev->current_release_bo[1])

	qxl_bo_unref(&qdev->current_release_bo[1]);

	flush_work(&qdev->gc_work);

	qxl_ring_free(qdev->command_ring);

CRA Git | Maintained and supported by SUSTech CRA and CCSE