Commit 765dd7a1 authored May 15, 2020 by Jesse Brandeburg Committed by Jeff Kirsher May 31, 2020

ice: Fix inability to set channels when down



Currently the driver prevents a user from doing
modprobe ice
ethtool -L eth0 combined 5
ip link set eth0 up

The ethtool command fails, because the driver is checking to see if the
interface is down before allowing the get_channels to proceed (even for
a set_channels).

Remove this check and allow the user to configure the interface
before bringing it up, which is a much better usability case.

Fixes: 87324e74 ("ice: Implement ethtool ops for channels")
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 401ce33b

drivers/net/ethernet/intel/ice/ice_ethtool.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -3189,10 +3189,6 @@ ice_get_channels(struct net_device dev, struct ethtool_channels ch)
		struct ice_vsi *vsi = np->vsi;
		struct ice_pf *pf = vsi->back;

		/* check to see if VSI is active */
		if (test_bit(__ICE_DOWN, vsi->state))
		return;

		/* report maximum channels */
		ch->max_rx = ice_get_max_rxq(pf);
		ch->max_tx = ice_get_max_txq(pf);

Admin message