Commit 765bda93 authored Mar 31, 2020 by Russell King Committed by David S. Miller Mar 31, 2020

net: dsa: fix oops while probing Marvell DSA switches



Fix an oops in dsa_port_phylink_mac_change() caused by a combination
of a20f9970 ("net: dsa: Don't instantiate phylink for CPU/DSA
ports unless needed") and the net-dsa-improve-serdes-integration
series of patches 65b7a2c8 ("Merge branch
'net-dsa-improve-serdes-integration'").

Unable to handle kernel NULL pointer dereference at virtual address 00000124
pgd = c0004000
[00000124] *pgd=00000000
Internal error: Oops: 805 [#1] SMP ARM
Modules linked in: tag_edsa spi_nor mtd xhci_plat_hcd mv88e6xxx(+) xhci_hcd armada_thermal marvell_cesa dsa_core ehci_orion libdes phy_armada38x_comphy at24 mcp3021 sfp evbug spi_orion sff mdio_i2c
CPU: 1 PID: 214 Comm: irq/55-mv88e6xx Not tainted 5.6.0+ #470
Hardware name: Marvell Armada 380/385 (Device Tree)
PC is at phylink_mac_change+0x10/0x88
LR is at mv88e6352_serdes_irq_status+0x74/0x94 [mv88e6xxx]

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 41c55ea6

net/dsa/slave.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1585,6 +1585,7 @@ void dsa_port_phylink_mac_change(struct dsa_switch *ds, int port, bool up)
		{
		const struct dsa_port *dp = dsa_to_port(ds, port);

		if (dp->pl)
		phylink_mac_change(dp->pl, up);
		}
		EXPORT_SYMBOL_GPL(dsa_port_phylink_mac_change);

Admin message