Commit 762c2916 authored Aug 27, 2010 by Akinobu Mita Committed by David S. Miller Aug 28, 2010

econet: kill unnecessary spin_lock_init()



The spinlock aun_queue_lock is initialized statically. It is unnecessary
to initialize by spin_lock_init() at module load time.

This is detected by the semantic patch.

// <smpl>
@def@
declarer name DEFINE_SPINLOCK;
identifier spinlock;
@@

DEFINE_SPINLOCK(spinlock);

@@
identifier def.spinlock;
@@

- spin_lock_init(&spinlock);
// </smpl>

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Julia Lawall <julia@diku.dk>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 034de00b

net/econet/af_econet.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1009,7 +1009,6 @@ static int __init aun_udp_initialise(void)
		struct sockaddr_in sin;

		skb_queue_head_init(&aun_queue);
		spin_lock_init(&aun_queue_lock);
		setup_timer(&ab_cleanup_timer, ab_cleanup, 0);
		ab_cleanup_timer.expires = jiffies + (HZ*2);
		add_timer(&ab_cleanup_timer);
		@@ -1167,7 +1166,6 @@ static int __init econet_proto_init(void)
		goto out;
		sock_register(&econet_family_ops);
		#ifdef CONFIG_ECONET_AUNUDP
		spin_lock_init(&aun_queue_lock);
		aun_udp_initialise();
		#endif
		#ifdef CONFIG_ECONET_NATIVE

Admin message