Commit 7626e3d0 authored Apr 27, 2014 by Dominique van den Broeck Committed by Greg Kroah-Hartman May 03, 2014

staging/rtl8192e: Erroneous return codes (types and values)

This function returns a bool, that is supposed to be false when something
goes wrong. It's assumed this way by its lone calling function (which is
SetRFPowerState8190(), line 1445 of rtl8192e/rtl8192e/r8192E_phy.c)

Despite of this, this procedure returns non-null enumerations values or
negative codes instead. This patch fixes this.

Signed-off-by: Dominique van den Broeck <domdevlin@free.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 73fbfbfe

drivers/staging/rtl8192e/rtl8192e/rtl_core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3029,7 +3029,7 @@ bool NicIFEnableNIC(struct net_device *dev)
		RT_TRACE(COMP_ERR, "ERR!!! %s(): Driver is already down!\n",
		__func__);
		priv->bdisable_nic = false;
		return RT_STATUS_FAILURE;
		return false;
		}

		RT_TRACE(COMP_PS, "===========>%s()\n", __func__);
		@@ -3039,7 +3039,7 @@ bool NicIFEnableNIC(struct net_device *dev)
		RT_TRACE(COMP_ERR, "ERR!!! %s(): initialization is failed!\n",
		__func__);
		priv->bdisable_nic = false;
		return -1;
		return false;
		}
		RT_TRACE(COMP_INIT, "start adapter finished\n");
		RT_CLEAR_PS_LEVEL(pPSC, RT_RF_OFF_LEVL_HALT_NIC);

Admin message