Commit 761e9f4f authored Apr 30, 2020 by Wei Yongjun Committed by Linus Walleij May 12, 2020

drm/mcde: dsi: Fix return value check in mcde_dsi_bind()

The of_drm_find_bridge() function returns NULL on error, it doesn't return
error pointers so this check doesn't work.

Fixes: 5fc537bf ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200430073145.52321-1-weiyongjun1@huawei.com

parent 81a15b9a

drivers/gpu/drm/mcde/mcde_dsi.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -1073,10 +1073,9 @@ static int mcde_dsi_bind(struct device dev, struct device master,
		panel = NULL;

		bridge = of_drm_find_bridge(child);
		if (IS_ERR(bridge)) {
		dev_err(dev, "failed to find bridge (%ld)\n",
		PTR_ERR(bridge));
		return PTR_ERR(bridge);
		if (!bridge) {
		dev_err(dev, "failed to find bridge\n");
		return -EINVAL;
		}
		}
		}