thermal: rcar_thermal: Always update thermal zone on interrupt (7617e771) · Commits · 戴 / test

Since commit ("thermal: rcar: check every rcar_thermal_update_temp() return value") the temperature is always read in rcar_thermal_get_current_temp() so comparing it before and after enabling interrupts have little effect. Remove the check and always update the thermal zone when we get an interrupt that the temperature have changed. Signed-off-by:

Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by:

Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by:

Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20200310170029.1648996-2-niklas.soderlund+renesas@ragnatech.se

drivers/thermal/rcar_thermal.c

+1 −12

Original line number	Diff line number	Diff line
		@@ -387,28 +387,17 @@ static void _rcar_thermal_irq_ctrl(struct rcar_thermal_priv *priv, int enable)
		static void rcar_thermal_work(struct work_struct *work)
		{
		struct rcar_thermal_priv *priv;
		int cctemp, nctemp;
		int ret;

		priv = container_of(work, struct rcar_thermal_priv, work.work);

		ret = rcar_thermal_get_current_temp(priv, &cctemp);
		if (ret < 0)
		return;

		ret = rcar_thermal_update_temp(priv);
		if (ret < 0)
		return;

		rcar_thermal_irq_enable(priv);

		ret = rcar_thermal_get_current_temp(priv, &nctemp);
		if (ret < 0)
		return;

		if (nctemp != cctemp)
		thermal_zone_device_update(priv->zone,
		THERMAL_EVENT_UNSPECIFIED);
		thermal_zone_device_update(priv->zone, THERMAL_EVENT_UNSPECIFIED);
		}

		static u32 rcar_thermal_had_changed(struct rcar_thermal_priv *priv, u32 status)

Admin message