Commit 760f86d7 authored Apr 16, 2005 by Herbert Xu Committed by Jeff Garzik May 15, 2005

[PATCH] Fw: [Bugme-new] [Bug 4482] New: natsemi: incorrect initialization of...

[PATCH] Fw: [Bugme-new] [Bug 4482] New: natsemi: incorrect initialization of IPv6 Neighbor-discovery multicast

On Wed, Apr 13, 2005 at 05:36:42PM +0000, Andrew Morton wrote:
>            Summary: natsemi: incorrect initialization of IPv6 Neighbor-
>                     discovery multicast

I've got a pair of FA312 cards and this problem has bothered me
for ages.  This has finally prompted me to do something about it :)

Turns out that somebody wasn't following the documentation.  We were
doing 16-bit writes to 32-bit registers which led to some addresses
working and others not so lucky.

This patch should fix the problem.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 88d7bd8c

drivers/net/natsemi.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -2433,8 +2433,8 @@ static void __set_rx_mode(struct net_device *dev)
		rx_mode = RxFilterEnable \| AcceptBroadcast
		\| AcceptMulticast \| AcceptMyPhys;
		for (i = 0; i < 64; i += 2) {
		writew(HASH_TABLE + i, ioaddr + RxFilterAddr);
		writew((mc_filter[i+1]<<8) + mc_filter[i],
		writel(HASH_TABLE + i, ioaddr + RxFilterAddr);
		writel((mc_filter[i + 1] << 8) + mc_filter[i],
		ioaddr + RxFilterData);
		}
		}

Admin message