Commit 75fc70e0 authored Aug 01, 2017 by Lukas Wunner Committed by Rafael J. Wysocki Aug 03, 2017

ACPI / property: Don't evaluate objects for devices w/o handle



Fabricated devices such as LNXPWRBN lack a handle, causing evaluation
of _CCA and _DSD to always fail with AE_BAD_PARAMETER.  While that is
merely a (negligible) waste of processing power, evaluating a _DSM for
them (such as Apple's device properties _DSM which we're about to add)
results in an ugly error:

    ACPI: \: failed to evaluate _DSM (0x1001)

Avoid by not evaluating _DSD and the upcoming _DSM for devices without
handle.

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 630b3aff

drivers/acpi/property.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -339,6 +339,9 @@ void acpi_init_properties(struct acpi_device *adev)

		INIT_LIST_HEAD(&adev->data.subnodes);

		if (!adev->handle)
		return;

		/*
		* Check if ACPI_DT_NAMESPACE_HID is present and inthat case we fill in
		* Device Tree compatible properties for this device.

Admin message