usb: dwc3: Free resource immediately after use (75ecb9dd) · Commits · 戴 / test

When we read an array of integers from device properties, the temporary buffer is allocated. However, in case of dwc3_set_incr_burst_type() it's not freed. Free allocated buffer immediately after use. Signed-off-by:

Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:

Felipe Balbi <felipe.balbi@linux.intel.com>

drivers/usb/dwc3/core.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -828,6 +828,7 @@ static void dwc3_set_incr_burst_type(struct dwc3 *dwc)
		ret = device_property_read_u32_array(dev,
		"snps,incr-burst-type-adjustment", vals, ntype);
		if (ret) {
		kfree(vals);
		dev_err(dev, "Error to get property\n");
		return;
		}
		@@ -846,6 +847,8 @@ static void dwc3_set_incr_burst_type(struct dwc3 *dwc)
		incrx_mode = INCRX_BURST_MODE;
		}

		kfree(vals);

		/* Enable Undefined Length INCR Burst and Enable INCRx Burst */
		cfg &= ~DWC3_GSBUSCFG0_INCRBRST_MASK;
		if (incrx_mode)

Admin message