drm: fsl-dcu: Rely on the default ->best_encoder() behavior (75e8c461) · Commits · 戴 / test

We have a 1:1 relationship between connectors and encoders and the driver is relying on the atomic helpers: we can drop the custom ->best_encoder() and let the core call drm_atomic_helper_best_encoder() for us. Signed-off-by:

Boris Brezillon <boris.brezillon@free-electrons.com> Signed-off-by:

Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/1465300095-16971-6-git-send-email-boris.brezillon@free-electrons.com

drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -102,14 +102,6 @@ static const struct drm_connector_funcs fsl_dcu_drm_connector_funcs = {
		.reset = drm_atomic_helper_connector_reset,
		};

		static struct drm_encoder *
		fsl_dcu_drm_connector_best_encoder(struct drm_connector *connector)
		{
		struct fsl_dcu_drm_connector *fsl_con = to_fsl_dcu_connector(connector);

		return fsl_con->encoder;
		}

		static int fsl_dcu_drm_connector_get_modes(struct drm_connector *connector)
		{
		struct fsl_dcu_drm_connector *fsl_connector;
		@@ -136,7 +128,6 @@ static int fsl_dcu_drm_connector_mode_valid(struct drm_connector *connector,
		}

		static const struct drm_connector_helper_funcs connector_helper_funcs = {
		.best_encoder = fsl_dcu_drm_connector_best_encoder,
		.get_modes = fsl_dcu_drm_connector_get_modes,
		.mode_valid = fsl_dcu_drm_connector_mode_valid,
		};

Admin message