Commit 75de7259 authored Jun 29, 2020 by Lee Jones Committed by Thierry Reding Jul 30, 2020

pwm: bcm-kona: Remove impossible comparison when validating duty cycle



'dc' here is an unsigned long, thus checking for <0 will always
evaluate to false.

Fixes the following W=1 warning:

 drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-pwm@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 9443f2c8

drivers/pwm/pwm-bcm-kona.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -138,7 +138,7 @@ static int kona_pwmc_config(struct pwm_chip chip, struct pwm_device pwm,
		dc = div64_u64(val, div);

		/* If duty_ns or period_ns are not achievable then return */
		if (pc < PERIOD_COUNT_MIN \|\| dc < DUTY_CYCLE_HIGH_MIN)
		if (pc < PERIOD_COUNT_MIN)
		return -EINVAL;

		/* If pc and dc are in bounds, the calculation is done */

Admin message