Commit 75d63a40 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] av7110: don't allow negative volumes 



The issue here is that we there is a static checker warning because we
have a user controlled volume setting and we cap the upper bound but we
allow negative numbers.  Negative volumes don't make sense, so let's
make these variables unsigned.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 4623e596

drivers/media/pci/ttpci/av7110_av.c

+4 −2
Original line number Diff line number Diff line
@@ -280,9 +280,11 @@ int av7110_pes_play(void *dest, struct dvb_ringbuffer *buf, int dlen) 
}





int av7110_set_volume(struct av7110 *av7110, int volleft, int volright)

int av7110_set_volume(struct av7110 *av7110, unsigned int volleft,

		      unsigned int volright)

{

	int err, vol, val, balance = 0;

	unsigned int vol, val, balance = 0;

	int err;



	dprintk(2, "av7110:%p, \n", av7110);

drivers/media/pci/ttpci/av7110_av.h

+2 −1
Original line number Diff line number Diff line
@@ -10,7 +10,8 @@ extern int av7110_record_cb(struct dvb_filter_pes2ts *p2t, u8 *buf, size_t len); 
extern int av7110_pes_play(void *dest, struct dvb_ringbuffer *buf, int dlen);

extern int av7110_write_to_decoder(struct dvb_demux_feed *feed, const u8 *buf, size_t len);



extern int av7110_set_volume(struct av7110 *av7110, int volleft, int volright);

extern int av7110_set_volume(struct av7110 *av7110, unsigned int volleft,

			     unsigned int volright);

extern int av7110_av_stop(struct av7110 *av7110, int av);

extern int av7110_av_start_record(struct av7110 *av7110, int av,

			  struct dvb_demux_feed *dvbdmxfeed);

CRA Git | Maintained and supported by SUSTech CRA and CCSE