Commit 75c1c825 authored Dec 04, 2010 by Changli Gao Committed by David S. Miller Dec 08, 2010

ifb: goto resched directly if error happens and dp->tq isn't empty



If we break the loop when there are still skbs in tq and no skb in
rq, the skbs will be left in txq until new skbs are enqueued into rq.
In rare cases, no new skb is queued, then these skbs will stay in rq
forever.

After this patch, if tq isn't empty when we break the loop, we goto
resched directly.

Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b1afde60

drivers/net/ifb.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -104,6 +104,8 @@ static void ri_tasklet(unsigned long dev)
		rcu_read_unlock();
		dev_kfree_skb(skb);
		stats->tx_dropped++;
		if (skb_queue_len(&dp->tq) != 0)
		goto resched;
		break;
		}
		rcu_read_unlock();

Admin message