Commit 75c08f17 authored Sep 18, 2015 by Tony Lindgren Committed by Lee Jones Oct 26, 2015

mfd: twl6040: Fix deferred probe handling for clk32k



Commit 68bab866 ("mfd: twl6040: Optional clk32k clock handling")
added clock handling for the 32k clock from palmas-clk. However, that
patch did not consider a typical situation where twl6040 is built-in,
and palmas-clk is a loadable module like we have in omap2plus_defconfig.

If palmas-clk is not loaded before twl6040 probes, we will get a
"clk32k is not handled" warning during booting. This means that any
drivers relying on this clock will mysteriously fail, including
omap5-uevm WLAN and audio.

Note that for WLAN, we probably should also eventually get
the clk32kgaudio for MMC3 directly as that's shared between
audio and WLAN SDIO at least for omap5-uevm. It seems the
WLAN chip cannot get it as otherwise MMC3 won't get properly
probed.

Fixes: 68bab866 ("mfd: twl6040: Optional clk32k clock handling")
Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent 62a2e633

drivers/mfd/twl6040.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -647,6 +647,8 @@ static int twl6040_probe(struct i2c_client *client,

		twl6040->clk32k = devm_clk_get(&client->dev, "clk32k");
		if (IS_ERR(twl6040->clk32k)) {
		if (PTR_ERR(twl6040->clk32k) == -EPROBE_DEFER)
		return -EPROBE_DEFER;
		dev_info(&client->dev, "clk32k is not handled\n");
		twl6040->clk32k = NULL;
		}

Admin message