parisc: Define O_NONBLOCK to become 000200000 (75ae0420) · Commits · 戴 / test

HPUX has separate NDELAY & NONBLOCK values. In the past we wanted to be able to run HP-UX binaries natively on parisc Linux which is why we defined O_NONBLOCK to 000200004 to distinguish NDELAY & NONBLOCK bits. But with 2 bits set in this bitmask we often ran into compatibility issues with other Linux applications which often only test one bit (or even compare the values). To avoid such issues in the future, this patch changes O_NONBLOCK to become 000200000. That way old programs will still be functional, and for new programs we now have only one bit set. Update the comment about SOCK_NONBLOCK too. Signed-off-by:

Helge Deller <deller@gmx.de>

arch/parisc/include/asm/socket.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -4,8 +4,8 @@

		#include <uapi/asm/socket.h>

		/* O_NONBLOCK clashes with the bits used for socket types. Therefore we
		* have to define SOCK_NONBLOCK to a different value here.
		/* O_NONBLOCK clashed with the bits used for socket types. Therefore we
		* had to define SOCK_NONBLOCK to a different value here.
		*/
		#define SOCK_NONBLOCK 0x40000000

arch/parisc/include/uapi/asm/fcntl.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -8,7 +8,7 @@
		#define O_LARGEFILE 000004000
		#define __O_SYNC 000100000
		#define O_SYNC (__O_SYNC\|O_DSYNC)
		#define O_NONBLOCK 000200004 /* HPUX has separate NDELAY & NONBLOCK */
		#define O_NONBLOCK 000200000
		#define O_NOCTTY 000400000 /* not fcntl */
		#define O_DSYNC 001000000
		#define O_NOATIME 004000000

Admin message