Commit 75a973c7 authored by Jonathan Cameron's avatar Jonathan Cameron Committed by Greg Kroah-Hartman
Browse files

staging:iio: Make read / write attributes for channel values optional. 



Until now all channels have had read/write attributes. This patch
allows for channels where we can't actually read the value (or for
output devices, write it!)

v2 introduces separate elements for processed and raw thus removing
some special case code from the core.  Thanks to Lars-Peter for an
excellent suggestion!

Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
Acked-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a8c0ed75

drivers/staging/iio/industrialio-core.c

+4 −16
Original line number Diff line number Diff line
@@ -80,6 +80,8 @@ static const char * const iio_modifier_names[] = { 


/* relies on pairs of these shared then separate */

static const char * const iio_chan_info_postfix[] = {

	[IIO_CHAN_INFO_RAW] = "raw",

	[IIO_CHAN_INFO_PROCESSED] = "input",

	[IIO_CHAN_INFO_SCALE] = "scale",

	[IIO_CHAN_INFO_OFFSET] = "offset",

	[IIO_CHAN_INFO_CALIBSCALE] = "calibscale",
@@ -577,26 +579,12 @@ static int iio_device_add_channel_sysfs(struct iio_dev *indio_dev, 
					struct iio_chan_spec const *chan)

{

	int ret, attrcount = 0;

	int i = 4;

	int i;

	const struct iio_chan_spec_ext_info *ext_info;



	if (chan->channel < 0)

		return 0;



	ret = __iio_add_chan_devattr(iio_data_type_name[chan->processed_val],

				     chan,

				     &iio_read_channel_info,

				     (chan->output ?

				      &iio_write_channel_info : NULL),

				     0,

				     0,

				     &indio_dev->dev,

				     &indio_dev->channel_attr_list);

	if (ret)

		goto error_ret;

	attrcount++;



	for_each_set_bit_from(i, &chan->info_mask, sizeof(long)*8) {

	for_each_set_bit(i, &chan->info_mask, sizeof(long)*8) {

		ret = __iio_add_chan_devattr(iio_chan_info_postfix[i/2],

					     chan,

					     &iio_read_channel_info,

CRA Git | Maintained and supported by SUSTech CRA and CCSE