kconfig: remove unneeded setsym label in conf_read_simple() (75889e9b) · Commits · 戴 / test

The two 'goto setsym' statements are reachable only when sym == NULL. The code below the 'setsym:' label does nothing when sym == NULL since there is just one if-block guarded by 'if (sym && ...)'. Hence, 'goto setsym' can be replaced with 'continue'. Signed-off-by:

Masahiro Yamada <yamada.masahiro@socionext.com>

scripts/kconfig/confdata.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -363,7 +363,7 @@ load:
		sym = sym_find(line + 2 + strlen(CONFIG_));
		if (!sym) {
		sym_add_change_count(1);
		goto setsym;
		continue;
		}
		} else {
		sym = sym_lookup(line + 2 + strlen(CONFIG_), 0);
		@@ -397,7 +397,7 @@ load:
		sym = sym_find(line + strlen(CONFIG_));
		if (!sym) {
		sym_add_change_count(1);
		goto setsym;
		continue;
		}
		} else {
		sym = sym_lookup(line + strlen(CONFIG_), 0);
		@@ -416,7 +416,7 @@ load:

		continue;
		}
		setsym:

		if (sym && sym_is_choice_value(sym)) {
		struct symbol *cs = prop_get_symbol(sym_get_choice_prop(sym));
		switch (sym->def[def].tri) {

Admin message