Commit 7582026f authored Feb 04, 2020 by Abhi Das Committed by Andreas Gruenbacher Feb 06, 2020

gfs2: fix gfs2_find_jhead that returns uninitialized jhead with seq 0



When the first log header in a journal happens to have a sequence
number of 0, a bug in gfs2_find_jhead() causes it to prematurely exit,
and return an uninitialized jhead with seq 0. This can cause failures
in the caller. For instance, a mount fails in one test case.

The correct behavior is for it to continue searching through the journal
to find the correct journal head with the highest sequence number.

Fixes: f4686c26 ("gfs2: read journal in large chunks")
Cc: stable@vger.kernel.org # v5.2+
Signed-off-by: Abhi Das <adas@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

parent a62aa6f7

fs/gfs2/lops.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -422,7 +422,7 @@ static bool gfs2_jhead_pg_srch(struct gfs2_jdesc *jd,

		for (offset = 0; offset < PAGE_SIZE; offset += sdp->sd_sb.sb_bsize) {
		if (!__get_log_header(sdp, kaddr + offset, 0, &lh)) {
		if (lh.lh_sequence > head->lh_sequence)
		if (lh.lh_sequence >= head->lh_sequence)
		*head = lh;
		else {
		ret = true;

Admin message