Commit 7574729e authored by Yazen Ghannam's avatar Yazen Ghannam Committed by Borislav Petkov
Browse files

EDAC/amd64: Cache secondary Chip Select registers 



AMD Family 17h systems have a set of secondary Chip Select Base
Addresses and Address Masks. These do not represent unique Chip
Selects, rather they are used in conjunction with the primary
Chip Select registers in certain cases.

Cache these secondary Chip Select registers for future use.

Signed-off-by: default avatarYazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Cc: James Morse <james.morse@arm.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
Link: https://lkml.kernel.org/r/20190821235938.118710-7-Yazen.Ghannam@amd.com
parent 8a2eaab7

drivers/edac/amd64_edac.c

+20 −3
Original line number Diff line number Diff line
@@ -946,34 +946,51 @@ static void prep_chip_selects(struct amd64_pvt *pvt) 


static void read_umc_base_mask(struct amd64_pvt *pvt)

{

	u32 umc_base_reg, umc_mask_reg;

	u32 base_reg, mask_reg;

	u32 *base, *mask;

	u32 umc_base_reg, umc_base_reg_sec;

	u32 umc_mask_reg, umc_mask_reg_sec;

	u32 base_reg, base_reg_sec;

	u32 mask_reg, mask_reg_sec;

	u32 *base, *base_sec;

	u32 *mask, *mask_sec;

	int cs, umc;



	for_each_umc(umc) {

		umc_base_reg = get_umc_base(umc) + UMCCH_BASE_ADDR;

		umc_base_reg_sec = get_umc_base(umc) + UMCCH_BASE_ADDR_SEC;



		for_each_chip_select(cs, umc, pvt) {

			base = &pvt->csels[umc].csbases[cs];

			base_sec = &pvt->csels[umc].csbases_sec[cs];



			base_reg = umc_base_reg + (cs * 4);

			base_reg_sec = umc_base_reg_sec + (cs * 4);



			if (!amd_smn_read(pvt->mc_node_id, base_reg, base))

				edac_dbg(0, "  DCSB%d[%d]=0x%08x reg: 0x%x\n",

					 umc, cs, *base, base_reg);



			if (!amd_smn_read(pvt->mc_node_id, base_reg_sec, base_sec))

				edac_dbg(0, "    DCSB_SEC%d[%d]=0x%08x reg: 0x%x\n",

					 umc, cs, *base_sec, base_reg_sec);

		}



		umc_mask_reg = get_umc_base(umc) + UMCCH_ADDR_MASK;

		umc_mask_reg_sec = get_umc_base(umc) + UMCCH_ADDR_MASK_SEC;



		for_each_chip_select_mask(cs, umc, pvt) {

			mask = &pvt->csels[umc].csmasks[cs];

			mask_sec = &pvt->csels[umc].csmasks_sec[cs];



			mask_reg = umc_mask_reg + (cs * 4);

			mask_reg_sec = umc_mask_reg_sec + (cs * 4);



			if (!amd_smn_read(pvt->mc_node_id, mask_reg, mask))

				edac_dbg(0, "  DCSM%d[%d]=0x%08x reg: 0x%x\n",

					 umc, cs, *mask, mask_reg);



			if (!amd_smn_read(pvt->mc_node_id, mask_reg_sec, mask_sec))

				edac_dbg(0, "    DCSM_SEC%d[%d]=0x%08x reg: 0x%x\n",

					 umc, cs, *mask_sec, mask_reg_sec);

		}

	}

}

drivers/edac/amd64_edac.h

+4 −0
Original line number Diff line number Diff line
@@ -259,7 +259,9 @@ 


/* UMC CH register offsets */

#define UMCCH_BASE_ADDR			0x0

#define UMCCH_BASE_ADDR_SEC		0x10

#define UMCCH_ADDR_MASK			0x20

#define UMCCH_ADDR_MASK_SEC		0x28

#define UMCCH_ADDR_CFG			0x30

#define UMCCH_DIMM_CFG			0x80

#define UMCCH_UMC_CFG			0x100
@@ -312,9 +314,11 @@ struct dram_range { 
/* A DCT chip selects collection */

struct chip_select {

	u32 csbases[NUM_CHIPSELECTS];

	u32 csbases_sec[NUM_CHIPSELECTS];

	u8 b_cnt;



	u32 csmasks[NUM_CHIPSELECTS];

	u32 csmasks_sec[NUM_CHIPSELECTS];

	u8 m_cnt;

};

CRA Git | Maintained and supported by SUSTech CRA and CCSE